klsince commented on code in PR #15296:
URL: https://github.com/apache/pinot/pull/15296#discussion_r1999319210
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1066,7 +1067,7 @@ protected SegmentBuildDescriptor
buildSegmentInternal(boolean forCommit) {
// for partial upsert tables, do not release
_partitionGroupConsumerSemaphore proactively and rely on offload()
// to release the semaphore. This ensures new consuming segment is not
consuming until the segment replacement is
// complete.
- if (_allowConsumptionDuringCommit) {
+ if (_allowConsumptionDuringBuild) {
Review Comment:
how about make this a helper method that takes a boolean param
downloadAndReplace, then we'll have a single method to do those checks, which
may be easier to maintain and extend later.
```
// for buildSegmentInternal()
if (allowConsumptionDuringCommit(false)) {
...
// for downloadSegmentAndReplace()
if (allowConsumptionDuringCommit(true)) {
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
