somandal commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2004099374
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -670,6 +686,26 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
serverSegmentChangeInfoMap.put(server, new
RebalanceSummaryResult.ServerSegmentChangeInfo(serverStatus,
totalNewSegments, totalExistingSegments, segmentsAdded,
segmentsDeleted, segmentsUnchanged,
instanceToTagsMap.getOrDefault(server, null)));
+ List<String> serverTags = getServerTag(server);
+ // Since this is a server in the target assignment, it should contain at
least one tag of the tenant or tier
+ // server tag. Note that if the server is tagged with multiple tenant or
tier tags that are used in the table
+ // config, we will count it multiple times, i.e. the total segment count
would not add up to the actual total.
+ if (serverTags.isEmpty()) {
Review Comment:
you still need a null check here? or use `CollectionUtils.isEmpty`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
