J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r1999788429
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##########
@@ -161,6 +170,62 @@ public int getExpectedValueAfterRebalance() {
}
}
+ public static class TenantInfo {
+ private final String _tenantName;
+ private int _numSegmentsUnchanged;
+ private int _numSegmentsReceived;
+ private int _numServerParticipants;
+
+ @JsonCreator
+ public TenantInfo(
+ @JsonProperty("tenantName") String tenantName,
+ @JsonProperty("numSegmentsReceived") int numSegmentsReceived,
Review Comment:
From server's perspective, `numSegmentsAdded` is indeed segments that will
be new to the server. But in this context, there could be segments moved from
`serverA` to `serverB` while these two servers are tagged with the same tenant.
Under this scenario segments are not "added".
Tbh "received" is also not accurate enough, do you have any suggestion here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
