J-HowHuang commented on code in PR #15233:
URL: https://github.com/apache/pinot/pull/15233#discussion_r1989972754
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##########
@@ -105,37 +102,87 @@ private Boolean checkReloadNeededOnServers(String
rebalanceJobId, String tableNa
LOGGER.warn("Caught exception while trying to fetch reload status from
servers", e);
}
- return needsReload;
+ return needsReload == null
+ ? RebalancePreCheckerResult.error("Could not determine needReload
status, run manually")
Review Comment:
Why is this an error while the previous one at L84 returns warning? They
have the same messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
