somandal commented on PR #15233: URL: https://github.com/apache/pinot/pull/15233#issuecomment-2711621849
> > Should we have a class like `PrecheckResult` with two members `_message` and `_status` which is an enum for different check result? (e.g. pass✅, warning⚠️, alert🚨), would it be clearer for the checker code and information showing if we're having more items added in? > > Yeah sure, that makes sense, but let's have a separate change for that which does this across all pre-checks. Can you take this change up after you get your disk utilization change in? Actually I decided to go ahead and make this change now itself since this suggestion is much cleaner and we can reduce number of changes around this by addressing this now. You'll need to rebase whenever this gets in though (or vice-versa if your changes get in first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
