9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1974942431
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##########
@@ -124,8 +136,24 @@ private void manageRetentionForTable(TableConfig
tableConfig) {
}
private void manageRetentionForOfflineTable(String offlineTableName,
RetentionStrategy retentionStrategy) {
Review Comment:
The support is present for realtime tables as well.
It is there right:
https://github.com/apache/pinot/pull/15142/files#diff-fc6f837f3641465c40ccf44fdded9bd37a3c7c9fb966d4710b2b034da5844759R225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
