ashishjayamohan commented on code in PR #14385:
URL: https://github.com/apache/pinot/pull/14385#discussion_r1972592399
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/TimestampIndexMseTest.java:
##########
@@ -85,23 +85,6 @@ public void timestampIndexSubstitutedInProjections() {
+ " FilterMatchEntireSegment(numDocs=[115545])\n");
}
- @Test
Review Comment:
Hmm.. Please correct me if I'm wrong, but I believe these tests are invalid
since these types of queries will be converted to range queries upstream.
Therefore, the timestamp index won't need to handle these types of filter
optimizations anymore (previously, it handled simple `dateTrunc` filters with
set timestamp index granularities)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
