9aman commented on code in PR #15048:
URL: https://github.com/apache/pinot/pull/15048#discussion_r1954035139
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -282,6 +284,23 @@ protected void removeSegmentFromStore(String
tableNameWithType, String segmentId
}
}
+ /**
+ * Gets URI for segment deletion by:
+ * 1. Fetching download URL from ZK metadata if available
+ * 2. Otherwise, constructing URI from data dir, table name and segment ID
+ */
+ private URI getFileToDeleteURI(String tableNameWithType, String segmentId) {
+ String segmentDownloadUrl =
Review Comment:
```
Standardization on url (in BaseMultipleSegmentsConversionExecutor and any
other places)
```
I will be taking up the issue of `Standardization` in another PR.
```
A failure between segment metadata clean up and DS clean up can happen at
which point we will not have the download URL
```
For this we need to make changes to the retention manager to:
1. Fetch deepstore url's for all the segments of the table using the list API
2. Delete the segment in case it's not present in the IS and has crossed
some retention/ creation duration threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
