swaminathanmanish commented on code in PR #15048:
URL: https://github.com/apache/pinot/pull/15048#discussion_r1954025962
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -282,6 +284,23 @@ protected void removeSegmentFromStore(String
tableNameWithType, String segmentId
}
}
+ /**
+ * Gets URI for segment deletion by:
+ * 1. Fetching download URL from ZK metadata if available
+ * 2. Otherwise, constructing URI from data dir, table name and segment ID
+ */
+ private URI getFileToDeleteURI(String tableNameWithType, String segmentId) {
+ String segmentDownloadUrl =
+
Optional.ofNullable(ZKMetadataProvider.getSegmentZKMetadata(_propertyStore,
tableNameWithType, segmentId))
Review Comment:
Looking at the call path **deleteSegmentFromPropertyStoreAndLocal ->
removeSegmentFromStore** . In deleteSegmentFromPropertyStoreAndLocal, we clean
up Zk metadata before calling removeSegmentFromStore, so we will never find Zk
metadata in removeSegmentFromStore.
Do we need to pass the download URL to removeSegmentFromStore ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
