Jackie-Jiang commented on code in PR #14994: URL: https://github.com/apache/pinot/pull/14994#discussion_r1943612524
########## pinot-spi/src/main/java/org/apache/pinot/spi/exception/QException.java: ########## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.exception; + +/** + * The base exception for query processing in Pinot. + * + * This exception is captured by the query engine and converted to a user-friendly message in a standardized format + * (ie converted into a JSON payload in an HTTP response). + * + * Contrary to {@code org.apache.pinot.common.response.ProcessingException}, which is usually designed to be thrown by + * {@code org.apache.pinot.common.exception.QueryException} in a non-allocating, non-throwing and stack-trace-less + * exception, this exception is designed to be thrown and caught by the query engine as any other standard Java + * exception. + */ +public class QException extends PinotRuntimeException { Review Comment: Suggest naming this `QueryException`. Since you are cleaning up `org.apache.pinot.common.exception.QueryException`, there is a TODO there to rename that to `QueryExceptionUtils`, and you can do it together to avoid name conflict ########## pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java: ########## @@ -614,28 +615,49 @@ public long toLong(Object value) { @Override public float toFloat(Object value) { // NOTE: No need to trim here because Float.valueOf() will trim the string - return Float.parseFloat(value.toString()); + try { Review Comment: This class is used in a lot of places and we want to ensure highest performance. It expects the input to be properly formatted, and it is not only used by the query engine. Can you do the try-catch on the caller side? ########## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ########## @@ -125,82 +127,211 @@ public void start() { public void shutDown() { _queryDispatcher.shutdown(); } - Review Comment: (nit) revert ########## pinot-spi/src/main/java/org/apache/pinot/spi/trace/MdcRequestScope.java: ########## @@ -0,0 +1,540 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.trace; + +import java.util.List; +import java.util.Map; + + +public class MdcRequestScope implements RequestScope { Review Comment: Please add some javadoc. What does `mdc` stand for? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
