gortiz opened a new pull request, #14994: URL: https://github.com/apache/pinot/pull/14994
This extensive PR is focused on improving error handling on MSE, but partially in SSE and TSE. Error handling includes changes in the error responses sent to clients but also logs in servers, brokers and controllers. Logging has been reduced to not logging stack traces when they are not useful. Logging is also improved to include the request-id in MSE and SSE queries and stage id in MSE queries. Instead of spreading the query context to all places where logs are created, this PR injects these values using [MDC](https://www.baeldung.com/mdc-in-log4j-2-logback). This means that: 1. Code doesn't have to change that much. 2. However, to modify the MDC in some parts, I needed to add a try-catch. I recommend reviewing the PR with the hidden white chances. 3. To log these properties, log4j2.xml needs to be changed. This PR includes a change in the log4j2.xml used for quickstars. Actual deployments will likely use their log4j2.xml files, and they will need to be modified to log request IDs and stage IDs. Please remember that this is optional. Logs are still as helpful as before, even if MDC properties are unused. Specifically, logs that already included the request ID or stage ID haven't been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
