gortiz commented on code in PR #14951:
URL: https://github.com/apache/pinot/pull/14951#discussion_r1942625995
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -398,18 +414,13 @@ private String getQueryURL(String protocol, String
hostName, int port) {
return String.format("%s://%s:%d/query/sql", protocol, hostName, port);
}
- public String sendPostRaw(String urlStr, String requestStr, Map<String,
String> headers) {
+ public void sendPostRaw(String urlStr, String requestStr, Map<String,
String> headers, OutputStream outputStream) {
HttpURLConnection conn = null;
try {
- /*if (LOG.isInfoEnabled()){
+ if (LOGGER.isInfoEnabled()) {
Review Comment:
Probably not. In general this longer way to log is less expensive in terms
of allocation that using the default:
```
LOGGER.info("some message with {} and {}", param1, param2)
```
Given this default uses varargs, which means that it allocates an array for
no reason if INFO is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
