gortiz commented on code in PR #14951:
URL: https://github.com/apache/pinot/pull/14951#discussion_r1942618169
##########
pinot-spi/src/main/java/org/apache/pinot/spi/exception/BadQueryRequestException.java:
##########
@@ -18,16 +18,28 @@
*/
package org.apache.pinot.spi.exception;
-public class BadQueryRequestException extends RuntimeException {
+public class BadQueryRequestException extends QException {
public BadQueryRequestException(String message) {
- super(message);
+ super(SQL_RUNTIME_ERROR_CODE, message);
Review Comment:
This class is used in tons of places to detect errors in runtime. There are
places where it is being caught and reconverted into a different error type
depending on the context where it was fired. For example
BaseSingleBlockCombineOperator.
Here, I'm assigning a default error code, which, in general, is something
difficult to do in a precise manner. Callers can anyway include an explicit
error code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
