This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-integration-testing.git
The following commit(s) were added to refs/heads/master by this push:
new 2e3c13a fixed the IT 4554 as LocalPort is -1 if Jetty connector is
not open. Error message in logs: [WARNING] Could not transfer metadata
org.apache.maven.its.mng4554/maven-metadata.xml from/to central
(http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1,
localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
2e3c13a is described below
commit 2e3c13a0a34304c866f8b8533090ab2cd6ecd1b4
Author: tibordigana <tibordig...@apache.org>
AuthorDate: Thu Aug 8 01:06:31 2019 +0200
fixed the IT 4554 as LocalPort is -1 if Jetty connector is not open. Error
message in logs: [WARNING] Could not transfer metadata
org.apache.maven.its.mng4554/maven-metadata.xml from/to central
(http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1,
localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
---
...avenITmng4554PluginPrefixMappingUpdateTest.java | 26 ++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
index 2955d65..c4e6979 100644
---
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
+++
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
@@ -85,7 +85,17 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
Server server = new Server( 0 );
server.setHandler( handlerList );
+ Connector connector = server.getConnectors()[0];
+ connector.setHost( "localhost" );
server.start();
+ while ( !server.isRunning() || !server.isStarted() )
+ {
+ if ( server.isFailed() )
+ {
+ fail( "Couldn't bind the server socket to a free port!" );
+ }
+ Thread.sleep( 100L );
+ }
Verifier verifier = newVerifier( testDir.getAbsolutePath() );
try
@@ -102,7 +112,7 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
assertFalse( new File( verifier.getArtifactMetadataPath(
"org.apache.maven.its.mng4554", null, null, "maven-metadata-mng4554.xml" )
).exists() );
}
Properties filterProps = verifier.newDefaultFilterProperties();
- filterProps.setProperty( "@port@", Integer.toString(
server.getConnectors()[0].getLocalPort() ) );
+ filterProps.setProperty( "@port@", Integer.toString(
connector.getLocalPort() ) );
filterProps.setProperty( "@repo@", "repo-1" );
verifier.filterFile( "settings-template.xml", "settings.xml",
"UTF-8", filterProps );
verifier.addCliOption( "-s" );
@@ -127,6 +137,7 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
{
verifier.resetStreams();
server.stop();
+ server.join();
}
}
@@ -162,7 +173,17 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
Server server = new Server( 0 );
server.setHandler( handlerList );
+ Connector connector = server.getConnectors()[0];
+ connector.setHost( "localhost" );
server.start();
+ while ( !server.isRunning() || !server.isStarted() )
+ {
+ if ( server.isFailed() )
+ {
+ fail( "Couldn't bind the server socket to a free port!" );
+ }
+ Thread.sleep( 100L );
+ }
Verifier verifier = newVerifier( testDir.getAbsolutePath() );
try
@@ -179,7 +200,7 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
assertFalse( new File( verifier.getArtifactMetadataPath(
"org.apache.maven.its.mng4554", null, null, "maven-metadata-mng4554.xml" )
).exists() );
}
Properties filterProps = verifier.newDefaultFilterProperties();
- filterProps.setProperty( "@port@", Integer.toString(
server.getConnectors()[0].getLocalPort() ) );
+ filterProps.setProperty( "@port@", Integer.toString(
connector.getLocalPort() ) );
filterProps.setProperty( "@repo@", "repo-1" );
verifier.filterFile( "settings-template.xml", "settings.xml",
"UTF-8", filterProps );
verifier.addCliOption( "-U" );
@@ -205,6 +226,7 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
{
verifier.resetStreams();
server.stop();
+ server.join();
}
}
