This is an automated email from the ASF dual-hosted git repository.

tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-integration-testing.git


The following commit(s) were added to refs/heads/master by this push:
     new 482756e  fixed the IT 4554 as LocalPort is -1 if Jetty connector is 
not open. Error message in logs: [WARNING] Could not transfer metadata 
org.apache.maven.its.mng4554/maven-metadata.xml from/to central 
(http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1, 
localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
482756e is described below

commit 482756ec1ff4b80c233bda949d187d7953144d47
Author: tibordigana <tibordig...@apache.org>
AuthorDate: Thu Aug 8 00:53:55 2019 +0200

    fixed the IT 4554 as LocalPort is -1 if Jetty connector is not open. Error 
message in logs: [WARNING] Could not transfer metadata 
org.apache.maven.its.mng4554/maven-metadata.xml from/to central 
(http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1, 
localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
---
 .../it/MavenITmng4554PluginPrefixMappingUpdateTest.java    | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git 
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
 
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
index 373a3e9..2955d65 100644
--- 
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
+++ 
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4554PluginPrefixMappingUpdateTest.java
@@ -32,6 +32,7 @@ import javax.servlet.http.HttpServletResponse;
 
 import org.apache.maven.it.util.ResourceExtractor;
 import org.apache.maven.shared.utils.io.FileUtils;
+import org.mortbay.jetty.Connector;
 import org.mortbay.jetty.Server;
 import org.mortbay.jetty.handler.AbstractHandler;
 import org.mortbay.jetty.handler.DefaultHandler;
@@ -241,7 +242,17 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
 
         Server server = new Server( 0 );
         server.setHandler( handlerList );
+        Connector connector = server.getConnectors()[0];
+        connector.setHost( "localhost" );
         server.start();
+        while ( !server.isRunning() || !server.isStarted() )
+        {
+            if ( server.isFailed() )
+            {
+                fail( "Couldn't bind the server socket to a free port!" );
+            }
+            Thread.sleep( 100L );
+        }
 
         Verifier verifier = newVerifier( testDir.getAbsolutePath() );
         try
@@ -258,7 +269,7 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
                 assertFalse( new File( verifier.getArtifactMetadataPath( 
"org.apache.maven.its.mng4554", null, null, "maven-metadata-mng4554.xml" ) 
).exists() );
             }
             Properties filterProps = verifier.newDefaultFilterProperties();
-            filterProps.setProperty( "@port@", Integer.toString( 
server.getConnectors()[0].getLocalPort() ) );
+            filterProps.setProperty( "@port@", Integer.toString( 
connector.getLocalPort() ) );
             filterProps.setProperty( "@repo@", "repo-it" );
             verifier.filterFile( "settings-template.xml", "settings.xml", 
"UTF-8", filterProps );
             verifier.addCliOption( "-s" );
@@ -288,6 +299,7 @@ public class MavenITmng4554PluginPrefixMappingUpdateTest
         {
             verifier.resetStreams();
             server.stop();
+            server.join();
         }
     }
 

Reply via email to