svn commit: r726417 - in /maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project: ModelUtils.java inheritance/DefaultModelInheritanceAssembler.java

[bentmann]

Author: bentmann
Date: Sun Dec 14 04:19:29 2008
New Revision: 726417

URL: http://svn.apache.org/viewvc?rev=726417&view=rev
Log:
[MNG-3906] Project-level plugin dependencies are in random order after merging

Modified:
    
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/ModelUtils.java
    
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java

Modified: 
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/ModelUtils.java
URL: 
http://svn.apache.org/viewvc/maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/ModelUtils.java?rev=726417&r1=726416&r2=726417&view=diff
==============================================================================
--- 
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/ModelUtils.java
 (original)
+++ 
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/ModelUtils.java
 Sun Dec 14 04:19:29 2008
@@ -1172,21 +1172,24 @@
     {
         Map depsMap = new LinkedHashMap();
 
-        if ( parent != null )
+        if ( child != null )
         {
-            for ( Iterator it = parent.iterator(); it.hasNext(); )
+            for ( Iterator it = child.iterator(); it.hasNext(); )
             {
                 Dependency dependency = (Dependency) it.next();
                 depsMap.put( dependency.getManagementKey(), dependency );
             }
         }
 
-        if ( child != null )
+        if ( parent != null )
         {
-            for ( Iterator it = child.iterator(); it.hasNext(); )
+            for ( Iterator it = parent.iterator(); it.hasNext(); )
             {
                 Dependency dependency = (Dependency) it.next();
-                depsMap.put( dependency.getManagementKey(), dependency );
+                if ( !depsMap.containsKey( dependency.getManagementKey() ) )
+                {
+                    depsMap.put( dependency.getManagementKey(), dependency );
+                }
             }
         }
 

Modified: 
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
URL: 
http://svn.apache.org/viewvc/maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=726417&r1=726416&r2=726417&view=diff
==============================================================================
--- 
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
 (original)
+++ 
maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
 Sun Dec 14 04:19:29 2008
@@ -34,7 +34,6 @@
 
 import java.util.ArrayList;
 import java.util.Iterator;
-import java.util.LinkedHashMap;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
@@ -249,34 +248,7 @@
 
     private void assembleDependencyInheritance( Model child, Model parent )
     {
-        Map depsMap = new LinkedHashMap();
-
-        List deps = child.getDependencies();
-
-        if ( deps != null )
-        {
-            for ( Iterator it = deps.iterator(); it.hasNext(); )
-            {
-                Dependency dependency = (Dependency) it.next();
-                depsMap.put( dependency.getManagementKey(), dependency );
-            }
-        }
-
-        deps = parent.getDependencies();
-
-        if ( deps != null )
-        {
-            for ( Iterator it = deps.iterator(); it.hasNext(); )
-            {
-                Dependency dependency = (Dependency) it.next();
-                if ( !depsMap.containsKey( dependency.getManagementKey() ) )
-                {
-                    depsMap.put( dependency.getManagementKey(), dependency );
-                }
-            }
-        }
-
-        child.setDependencies( new ArrayList( depsMap.values() ) );
+        child.setDependencies( ModelUtils.mergeDependencyList( 
child.getDependencies(), parent.getDependencies() ) );
     }
 
     private void assembleBuildInheritance( Model child, Model parent )