Author: bentmann Date: Sun Dec 14 02:59:28 2008 New Revision: 726412 URL: http://svn.apache.org/viewvc?rev=726412&view=rev Log: [MNG-3904] Fix interpolation of recursively nested build properties
o Added IT Added: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3904NestedBuildDirInterpolationTest.java (with props) maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/ maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/pom.xml (with props) Modified: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java Modified: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java?rev=726412&r1=726411&r2=726412&view=diff ============================================================================== --- maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java (original) +++ maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java Sun Dec 14 02:59:28 2008 @@ -90,6 +90,7 @@ // suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class ); // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137 + suite.addTestSuite( MavenITmng3904NestedBuildDirInterpolationTest.class ); suite.addTestSuite( MavenITmng3900ProfilePropertiesInterpolationTest.class ); suite.addTestSuite( MavenITmng3899ExtensionInheritanceTest.class ); suite.addTestSuite( MavenITmng3892ReleaseDeploymentTest.class ); Added: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3904NestedBuildDirInterpolationTest.java URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3904NestedBuildDirInterpolationTest.java?rev=726412&view=auto ============================================================================== --- maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3904NestedBuildDirInterpolationTest.java (added) +++ maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3904NestedBuildDirInterpolationTest.java Sun Dec 14 02:59:28 2008 @@ -0,0 +1,68 @@ +package org.apache.maven.it; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.it.Verifier; +import org.apache.maven.it.util.ResourceExtractor; + +import java.io.File; +import java.util.Properties; + +/** + * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-3904">MNG-3904</a>. + * + * @author Benjamin Bentmann + * @version $Id$ + */ +public class MavenITmng3904NestedBuildDirInterpolationTest + extends AbstractMavenIntegrationTestCase +{ + + public MavenITmng3904NestedBuildDirInterpolationTest() + { + super( "[2.1.0-M1,)" ); + } + + /** + * Test that properties which refer to build directories which in turn refer to other build directories are + * properly interpolated. + */ + public void testitMNG3904() + throws Exception + { + File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-3904" ); + + Verifier verifier = new Verifier( testDir.getAbsolutePath() ); + verifier.setAutoclean( false ); + verifier.deleteDirectory( "target" ); + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + verifier.resetStreams(); + + Properties props = verifier.loadProperties( "target/pom.properties" ); + assertEquals( new File( testDir, "target/classes/dir0" ), + new File( props.getProperty( "project.properties.dir0" ) ) ); + assertEquals( new File( testDir, "src/test/dir1" ), + new File( props.getProperty( "project.properties.dir1" ) ) ); + assertEquals( new File( testDir, "target/site/dir2" ), + new File( props.getProperty( "project.properties.dir2" ) ) ); + } + +} Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3904NestedBuildDirInterpolationTest.java ------------------------------------------------------------------------------ svn:eol-style = native Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3904NestedBuildDirInterpolationTest.java ------------------------------------------------------------------------------ svn:keywords = Author Date Id Revision Added: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/pom.xml URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/pom.xml?rev=726412&view=auto ============================================================================== --- maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/pom.xml (added) +++ maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/pom.xml Sun Dec 14 02:59:28 2008 @@ -0,0 +1,77 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<project> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.maven.its.mng3904</groupId> + <artifactId>test</artifactId> + <version>0.1</version> + <packaging>jar</packaging> + + <name>Maven Integration Test :: MNG-3904</name> + <description> + Test that properties which refer to build directories which in turn refer to other build directories are + properly interpolated. + </description> + + <properties> + <!-- These are the properties of interest --> + <dir0>${project.build.outputDirectory}/dir0</dir0> + <dir1>${project.build.testSourceDirectory}/dir1</dir1> + <dir2>${project.reporting.outputDirectory}/dir2</dir2> + </properties> + + <build> + <!-- Test properties which finally refer to ${project.basedir} --> + <directory>${project.basedir}/target</directory> + <outputDirectory>${project.build.directory}/classes</outputDirectory> + <!-- Test properties which finally refer to ${basedir} --> + <sourceDirectory>${basedir}/src</sourceDirectory> + <testSourceDirectory>${project.build.sourceDirectory}/test</testSourceDirectory> + + <plugins> + <plugin> + <groupId>org.apache.maven.its.plugins</groupId> + <artifactId>maven-it-plugin-expression</artifactId> + <version>2.1-SNAPSHOT</version> + <executions> + <execution> + <phase>validate</phase> + <goals> + <goal>eval</goal> + </goals> + <configuration> + <outputFile>target/pom.properties</outputFile> + <expressions> + <expression>project/properties</expression> + </expressions> + </configuration> + </execution> + </executions> + </plugin> + </plugins> + </build> + + <reporting> + <outputDirectory>${project.build.directory}/site</outputDirectory> + </reporting> +</project> Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/pom.xml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3904/pom.xml ------------------------------------------------------------------------------ svn:keywords = Author Date Id Revision