askhatri commented on code in PR #384:
URL: https://github.com/apache/incubator-livy/pull/384#discussion_r1092752125
##########
server/src/main/scala/org/apache/livy/sessions/SessionManager.scala:
##########
@@ -168,7 +169,9 @@ class SessionManager[S <: Session, R <: RecoveryMetadata :
ClassTag](
false
} else {
val currentTime = System.nanoTime()
- currentTime - session.lastActivity > sessionTimeout
+ val calculatedTimeout =
Review Comment:
I got it @ksumit . So presently we have three options now:
1) Use "ttl" with "String" datatype and keep parsing logic same as global
config.
2) Change filed name to "ttlInMinutes" with "Int" datatype and support only
minutes in user inputs.
3) Change filed name to "ttlInSeconds" with "Int" datatype and support only
seconds in user inputs.
Since the logic to parse string already and it is consistent with global
configuration we are planing to go with option 1. i.e. using "ttl" field as
"String".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
