ksumit commented on code in PR #384:
URL: https://github.com/apache/incubator-livy/pull/384#discussion_r1089796453
##########
server/src/main/scala/org/apache/livy/sessions/SessionManager.scala:
##########
@@ -168,7 +169,9 @@ class SessionManager[S <: Session, R <: RecoveryMetadata :
ClassTag](
false
} else {
val currentTime = System.nanoTime()
- currentTime - session.lastActivity > sessionTimeout
+ val calculatedTimeout =
Review Comment:
hi @askhatri, i should have been more specific, i had following specific
concerns:
1. the logic on parsing the string and converting it to seconds,
milliseconds etc seems more complex. instead i was proposing that we use `Int`
or `Long` and use number to denote the ttl value
2. fix the granularity for ttl either in minutes or seconds to avoid the
complexity
3. depending on whether we fix it in minutes or seconds to be very explicit,
name the variable as `ttlInMinutes` or `ttlInSeconds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
