yesamer commented on code in PR #3881:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3881#discussion_r2031027652
##########
kogito-codegen-modules/kogito-codegen-manager/src/main/java/org/kie/kogito/codegen/manager/CompilerHelper.java:
##########
@@ -93,21 +98,37 @@ static void
compileAndWriteClasses(Collection<GeneratedFile> generatedClasses, C
}
if (sources.length > 0) {
+ CompilationResult result = JAVA_COMPILER.compile(sources, srcMfs,
trgMfs, classLoader, javaCompilerSettings);
- CompilationResult result = JAVA_COMPILER.compile(sources, srcMfs,
trgMfs, cl, settings);
if (result.getErrors().length > 0) {
- throw new
MojoFailureException(Arrays.toString(result.getErrors()));
+ throw new
IllegalStateException(Arrays.stream(result.getErrors())
+ .map(CompilationProblem::getMessage)
+ .collect(Collectors.joining(",")));
}
for (PortablePath path : trgMfs.getFilePaths()) {
byte[] data = trgMfs.getBytes(path);
- writeGeneratedFile(new
GeneratedFile(GeneratedFileType.COMPILED_CLASS, path.asString(), data),
fileWriter, log);
+ writeGeneratedFile(new
GeneratedFile(GeneratedFileType.COMPILED_CLASS, path.asString(), data),
fileWriter);
}
}
}
- private static GeneratedFileWriter getGeneratedFileWriter(File baseDir) {
- return generatedFileWriterBuilder
- .build(Path.of(baseDir.getAbsolutePath()));
+ static GeneratedFileWriter getGeneratedFileWriter(File baseDir) {
+ return
GENERATED_FILE_WRITER_BUILDER.build(Path.of(baseDir.getAbsolutePath()));
+ }
+
+ static JavaCompilerSettings getJavaCompilerSettings(List<String>
runtimeClassPathElements,
Review Comment:
Done
##########
kogito-codegen-modules/kogito-codegen-manager/src/main/java/org/kie/kogito/codegen/manager/CompilerHelper.java:
##########
@@ -93,21 +98,37 @@ static void
compileAndWriteClasses(Collection<GeneratedFile> generatedClasses, C
}
if (sources.length > 0) {
+ CompilationResult result = JAVA_COMPILER.compile(sources, srcMfs,
trgMfs, classLoader, javaCompilerSettings);
- CompilationResult result = JAVA_COMPILER.compile(sources, srcMfs,
trgMfs, cl, settings);
if (result.getErrors().length > 0) {
- throw new
MojoFailureException(Arrays.toString(result.getErrors()));
+ throw new
IllegalStateException(Arrays.stream(result.getErrors())
+ .map(CompilationProblem::getMessage)
+ .collect(Collectors.joining(",")));
}
for (PortablePath path : trgMfs.getFilePaths()) {
byte[] data = trgMfs.getBytes(path);
- writeGeneratedFile(new
GeneratedFile(GeneratedFileType.COMPILED_CLASS, path.asString(), data),
fileWriter, log);
+ writeGeneratedFile(new
GeneratedFile(GeneratedFileType.COMPILED_CLASS, path.asString(), data),
fileWriter);
}
}
}
- private static GeneratedFileWriter getGeneratedFileWriter(File baseDir) {
- return generatedFileWriterBuilder
- .build(Path.of(baseDir.getAbsolutePath()));
+ static GeneratedFileWriter getGeneratedFileWriter(File baseDir) {
+ return
GENERATED_FILE_WRITER_BUILDER.build(Path.of(baseDir.getAbsolutePath()));
+ }
+
+ static JavaCompilerSettings getJavaCompilerSettings(List<String>
runtimeClassPathElements,
+ String sourceEncoding,
+ String sourceVersion,
+ String targetVersion) {
+ JavaCompilerSettings settings = new JavaCompilerSettings();
+ for (String path : runtimeClassPathElements) {
+ File pathFile = new File(path);
+ settings.addClasspath(pathFile);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
