yesamer commented on code in PR #3881:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3881#discussion_r2030889986
##########
kogito-maven-plugin/src/main/java/org/kie/kogito/maven/plugin/GenerateModelMojo.java:
##########
@@ -83,11 +76,17 @@ public class GenerateModelMojo extends AbstractKieMojo {
/**
* The <code>maven-compiler-plugin</code> version to use.
- * Default to <b>3.8.1</b>
+ * Default to <b>3.10.2</b>
*/
- @Parameter(defaultValue = "3.8.1", property = "version.compiler.plugin")
+ @Parameter(defaultValue = "3.10.2", property = "version.compiler.plugin")
private String compilerPluginVersion;
+ @Parameter(defaultValue = "1.8", property = "maven.compiler.source")
+ private String compilerSourceJavaVersion;
Review Comment:
@gitgabrio That (and all 1.8 values) are set as default values. I set 1.8
because that is the default for `maven.compiler.source` and
`maven.compiler.target`
(https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#target).
However, I guess it should be fine to set the default to 17, I guess that
wouldn't impact the functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
