voonhous commented on code in PR #18483:
URL: https://github.com/apache/hudi/pull/18483#discussion_r3072431804
##########
hudi-gcp/src/test/java/org/apache/hudi/gcp/bigquery/TestBigQuerySchemaResolver.java:
##########
@@ -280,4 +280,21 @@ void getTableSchema_withoutPartitionFields() throws
Exception {
BigQuerySchemaResolver resolver = new BigQuerySchemaResolver(metaClient ->
mockTableSchemaResolver);
Assertions.assertEquals(PRIMITIVE_TYPES_BQ_SCHEMA,
resolver.getTableSchema(mockMetaClient, Collections.emptyList()));
}
+
+ @Test
+ void convertSchema_variantField() {
Review Comment:
The other tests in this file uses a combination of `camelCase_snakeCase` for
naming tests. So, i think it's okay to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]