bvaradar commented on code in PR #18483:
URL: https://github.com/apache/hudi/pull/18483#discussion_r3060374315
##########
hudi-gcp/src/test/java/org/apache/hudi/gcp/bigquery/TestBigQuerySchemaResolver.java:
##########
@@ -280,4 +280,21 @@ void getTableSchema_withoutPartitionFields() throws
Exception {
BigQuerySchemaResolver resolver = new BigQuerySchemaResolver(metaClient ->
mockTableSchemaResolver);
Assertions.assertEquals(PRIMITIVE_TYPES_BQ_SCHEMA,
resolver.getTableSchema(mockMetaClient, Collections.emptyList()));
}
+
+ @Test
+ void convertSchema_variantField() {
Review Comment:
nit: kindly use camelcase
##########
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestSparkSchemaUtils.java:
##########
@@ -194,4 +194,25 @@ public void testConvertSchemaWithBlobField() {
StructType blobStruct = (StructType) sparkSchema.fields()[1].dataType();
assertEquals(3, blobStruct.fields().length);
}
+
+ @Test
+ public void testConvertSchemaWithVariantField() {
+ HoodieSchema schema = HoodieSchema.createRecord("root", null, null, false,
Arrays.asList(
Review Comment:
can we also cover nested variants ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
