yihua commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3035648231
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -67,13 +66,13 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O>
create(
log.info("Create HoodieMergeHandle implementation {} {}",
mergeHandleClasses.getLeft(), logContext);
Class<?>[] constructorParamTypes = new Class<?>[] {
- HoodieWriteConfig.class, String.class, HoodieTable.class,
Iterator.class,
+ HoodieWriteConfig.class, String.class, HoodieTable.class,
MergeContext.class,
Review Comment:
🤖 The constructor lookup now requires `MergeContext.class` instead of
`Iterator.class`. This is a breaking change for any custom merge handle
implementations registered via config — their constructors won't be found by
reflection. Would it be worth adding a fallback that tries the old
`Iterator.class` signature, or at least documenting the migration in the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
