yihua commented on code in PR #18401:
URL: https://github.com/apache/hudi/pull/18401#discussion_r3035636250
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java:
##########
@@ -148,6 +155,17 @@ public interface SchemaConverter {
String convert(ParsedSchema schema) throws IOException;
}
+ private static Map<String, Object>
extractSchemaRegistryConfigs(TypedProperties config) {
+ Map<String, Object> schemaRegistryConfigs = new HashMap<>();
+ config.forEach((k, v) -> {
+ String key = k.toString();
Review Comment:
🤖 nit: the `v != null` guard is unreachable — `TypedProperties` extends
`Properties` which extends `Hashtable`, and `Hashtable` never allows null
values. This is also what's causing the partial-branch warning in Codecov.
Dropping it would simplify the predicate to just the prefix check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
