lasdf1234 commented on code in PR #10967: URL: https://github.com/apache/gravitino/pull/10967#discussion_r3192689849
########## authenticators/authenticator-basic/build.gradle.kts: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { Review Comment: May be 'Add password hashing support' should be the first sub task(https://github.com/apache/gravitino/issues/10961)? This sub-task is the most basic one, and it has accomplished the most basic functions of the authenticator-basic module. If this sub task is the first sub task, I will adjust the sequence of the sub-tasks, and then you can review the code. How about that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
