Copilot commented on code in PR #10967: URL: https://github.com/apache/gravitino/pull/10967#discussion_r3182234558
########## authenticators/authenticator-basic/src/main/java/org/apache/gravitino/auth/local/BasicAuthenticator.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.auth.local; + +import java.nio.charset.StandardCharsets; +import java.security.Principal; +import java.util.Base64; +import org.apache.gravitino.Config; +import org.apache.gravitino.UserPrincipal; +import org.apache.gravitino.auth.AuthConstants; +import org.apache.gravitino.exceptions.BadRequestException; +import org.apache.gravitino.exceptions.UnauthorizedException; +import org.apache.gravitino.server.authentication.Authenticator; + +/** + * Basic authenticator wiring for the local authentication module. + * + * <p>The credential verification flow will be implemented in follow-up subtasks. For now, keep the + * current Basic header parsing behavior so the module can be loaded safely when {@code + * gravitino.authenticators=basic}. + */ +public class BasicAuthenticator implements Authenticator { + private static final String BASIC_AUTH_CHALLENGE = "Basic"; + + @Override + public boolean isDataFromToken() { + return true; + } + + @Override + public Principal authenticateToken(byte[] tokenData) { + if (tokenData == null) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + String authData = new String(tokenData, StandardCharsets.UTF_8); + if (authData.trim().isEmpty()) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + if (!authData.startsWith(AuthConstants.AUTHORIZATION_BASIC_HEADER)) { + throw new UnauthorizedException("Invalid token authorization header", BASIC_AUTH_CHALLENGE); + } + + String credential = authData.substring(AuthConstants.AUTHORIZATION_BASIC_HEADER.length()); + if (credential.trim().isEmpty()) { + throw new BadRequestException("Malformed Basic authorization header: missing credentials"); + } + + try { + String decodedCredential = + new String(Base64.getDecoder().decode(credential), StandardCharsets.UTF_8); + int separatorIndex = decodedCredential.indexOf(':'); + if (separatorIndex < 0) { + throw new BadRequestException( + "Malformed Basic authorization header: credentials must be in username:password format"); + } + + String userName = decodedCredential.substring(0, separatorIndex); + if (userName.isEmpty()) { + throw new BadRequestException( + "Malformed Basic authorization header: username must not be empty"); + } + + return new UserPrincipal(userName, authData); + } catch (IllegalArgumentException e) { + throw new BadRequestException(e, "Malformed Basic authorization header: invalid base64"); + } + } + + @Override + public void initialize(Config config) { + // no-op + } + + @Override + public boolean supportsToken(byte[] tokenData) { + return tokenData != null + && new String(tokenData, StandardCharsets.UTF_8) + .startsWith(AuthConstants.AUTHORIZATION_BASIC_HEADER); Review Comment: `supportsToken` returns false for null/blank Authorization headers, so `AuthenticationFilter` will never call `authenticateToken(null)` and the authenticator cannot emit the intended `UnauthorizedException` with a `WWW-Authenticate: Basic` challenge. If BASIC auth is enabled, consider treating null/blank headers as “supported” so this authenticator can drive the correct 401 + challenge response (or adjust `AuthenticationFilter` to request challenges when the header is missing). ########## authenticators/authenticator-basic/src/test/java/org/apache/gravitino/auth/local/TestBasicAuthenticator.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.auth.local; + +import java.nio.charset.StandardCharsets; +import org.apache.gravitino.auth.AuthConstants; +import org.apache.gravitino.exceptions.BadRequestException; +import org.apache.gravitino.exceptions.UnauthorizedException; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +public class TestBasicAuthenticator { + + private final BasicAuthenticator authenticator = new BasicAuthenticator(); + + @Test + public void testAuthenticateTokenThrowsUnauthorizedWhenHeaderMissing() { + UnauthorizedException exception = + Assertions.assertThrows( + UnauthorizedException.class, () -> authenticator.authenticateToken(null)); + + Assertions.assertEquals("Empty token authorization header", exception.getMessage()); + Assertions.assertEquals("Basic", exception.getChallenges().get(0)); + } Review Comment: These tests call `authenticateToken(null|blank)` directly, but in the actual server flow `AuthenticationFilter` calls `authenticateToken` only when `supportsToken` returns true. As implemented, BASIC `supportsToken` rejects null/blank inputs, so these scenarios won’t be exercised end-to-end. Add a filter-level test that asserts the 401 response + `WWW-Authenticate: Basic` challenge for missing/blank Authorization headers (or adjust `supportsToken` accordingly). ########## authenticators/authenticator-basic/src/main/java/org/apache/gravitino/auth/local/BasicAuthenticator.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.auth.local; + +import java.nio.charset.StandardCharsets; +import java.security.Principal; +import java.util.Base64; +import org.apache.gravitino.Config; +import org.apache.gravitino.UserPrincipal; +import org.apache.gravitino.auth.AuthConstants; +import org.apache.gravitino.exceptions.BadRequestException; +import org.apache.gravitino.exceptions.UnauthorizedException; +import org.apache.gravitino.server.authentication.Authenticator; + +/** + * Basic authenticator wiring for the local authentication module. + * + * <p>The credential verification flow will be implemented in follow-up subtasks. For now, keep the + * current Basic header parsing behavior so the module can be loaded safely when {@code + * gravitino.authenticators=basic}. + */ +public class BasicAuthenticator implements Authenticator { + private static final String BASIC_AUTH_CHALLENGE = "Basic"; + + @Override + public boolean isDataFromToken() { + return true; + } + + @Override + public Principal authenticateToken(byte[] tokenData) { + if (tokenData == null) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + String authData = new String(tokenData, StandardCharsets.UTF_8); + if (authData.trim().isEmpty()) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + if (!authData.startsWith(AuthConstants.AUTHORIZATION_BASIC_HEADER)) { + throw new UnauthorizedException("Invalid token authorization header", BASIC_AUTH_CHALLENGE); + } + + String credential = authData.substring(AuthConstants.AUTHORIZATION_BASIC_HEADER.length()); + if (credential.trim().isEmpty()) { + throw new BadRequestException("Malformed Basic authorization header: missing credentials"); + } + + try { + String decodedCredential = + new String(Base64.getDecoder().decode(credential), StandardCharsets.UTF_8); + int separatorIndex = decodedCredential.indexOf(':'); + if (separatorIndex < 0) { + throw new BadRequestException( + "Malformed Basic authorization header: credentials must be in username:password format"); + } + + String userName = decodedCredential.substring(0, separatorIndex); + if (userName.isEmpty()) { + throw new BadRequestException( + "Malformed Basic authorization header: username must not be empty"); + } + + return new UserPrincipal(userName, authData); + } catch (IllegalArgumentException e) { + throw new BadRequestException(e, "Malformed Basic authorization header: invalid base64"); + } Review Comment: `authenticateToken` currently returns a `UserPrincipal` for any syntactically valid Basic header without verifying the password/credential. With `gravitino.authenticators=basic`, this effectively allows user impersonation. Until credential verification is implemented, this should fail closed (e.g., always throw `UnauthorizedException` after parsing) or be gated behind an explicit “insecure/dev mode” config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
