sachinnn99 commented on PR #10699: URL: https://github.com/apache/gravitino/pull/10699#issuecomment-4277902845
@laserninja Good question — the current code does include the `if (catalog instanceof RESTCatalog)` branch for `registerTable`, delegating to `registerTableInternal()` before credential injection, matching the same pattern as `createTable` and `loadTable`. When the underlying catalog is a `RESTCatalog`, `shouldGenerateCredential` returns `false` (via the `getCatalog() instanceof RESTCatalog` check), so Gravitino correctly defers credential vending to the upstream catalog. The upstream Iceberg `RESTSessionCatalog.registerTable` doesn't forward `X-Iceberg-Access-Delegation` as an explicit header — it uses `mutationHeaders` (idempotency headers only). But it doesn't need to: it processes the upstream response's credentials via `response.credentials()` and wires them into the `RESTTableOperations` / `tableFileIO`. So the chain works correctly end-to-end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
