laserninja commented on PR #10699: URL: https://github.com/apache/gravitino/pull/10699#issuecomment-4241206830
In `createTable` and `loadTable`, `CatalogWrapperForREST` checks `if (catalog instanceof RESTCatalog)` and delegates to `*Internal()` methods before credential injection. The new `registerTable` skips this branch and calls `super.registerTable()` directly. Could you confirm this works correctly when the underlying catalog is a `RESTCatalog` (i.e., Gravitino fronting another Iceberg REST catalog)? If the upstream catalog already handles credential vending, the `shouldGenerateCredential` gate (`getCatalog() instanceof RESTCatalog → return false`) would short-circuit correctly, but it would be good to verify that `RESTCatalog.registerTable` properly forwards the `X-Iceberg-Access-Delegation` header upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
