echonesis commented on code in PR #9960:
URL: https://github.com/apache/gravitino/pull/9960#discussion_r3108138583
##########
api/src/main/java/org/apache/gravitino/job/JobTemplate.java:
##########
@@ -73,7 +73,25 @@ public enum JobType {
/** The executable path for the job template. */
protected final String executable;
- /** The list of arguments for the job template. */
+ /**
+ * The list of arguments for the job template.
+ *
+ * <p>Arguments can be marked as optional by prefixing them with {@code ?}.
An optional argument
+ * is filtered out at job execution time if its effective value is
considered empty. A value is
+ * empty when it is {@code null}, an empty string, whitespace-only, or an
unreplaced placeholder
+ * (i.e., the key was absent from the job configuration).
+ *
+ * <p>Two consecutive optional arguments can form a flag-value pair. When
the flag (the first
Review Comment:
Sorry for the late response.
Sure, I totally understand the concern about complexity. Just want to make
sure I'm aligned with your expectation.
If a user writes `["--conf", "?{{spark_conf}}"]` and `spark_conf` is absent,
what would the expected behavior be? And is there a recommended way for users
to handle this case correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
