arjnklc opened a new pull request, #10815:
URL: https://github.com/apache/gravitino/pull/10815

   ### What changes were proposed in this pull request?
   
   Fixed logging in `PartitionOperations.dropPartition` to only emit the 
success log when the partition is actually dropped/purged:
   - Moved the success `LOG.info` inside an `else` block so it only fires when 
`dropped == true`.
   - Improved the warning log to include the operation type (`drop`/`purge`) 
instead of hardcoding "drop".
   - Removed an unnecessary intermediate `response` variable.
   
   ### Why are the changes needed?
   
   The success `LOG.info` message was emitted unconditionally, even when the 
deletion returned `false`. This caused misleading log output where a warning 
about a failed drop was immediately followed by a success message for the same 
operation.
   
   Fix: #10216
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. This is an internal logging improvement. The REST API response is 
unchanged.
   
   ### How was this patch tested?
   
   Ran existing unit tests to verify no regressions:
   ```
   ./gradlew :server:test --tests 
"org.apache.gravitino.server.web.rest.TestPartitionOperations" -PskipITs
   ```
   All tests pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to