sachinnn99 commented on PR #10748: URL: https://github.com/apache/gravitino/pull/10748#issuecomment-4258828748
@diqiu50 Pushed an update addressing your feedback: **1. Version support matrix** (`supportCatalogNameWithMetalake`) - 435-451 — `true` (unchanged from main) - 469-478 — `true` (enabled by this PR) - 452-468 — `false` (unchanged) **2. Unsupported version behavior** - Changed from throwing `TrinoException` to `LOG.warn` noting that `DROP CATALOG` may not work correctly. **3. Tests** - Enabled `MultiMetalake` test for 469-472 and 473-478 — verified passing locally. - Left `MultiMetalake` test `@Disabled` for 446-451 (matching main). Locally, after experimentally enabling the test and adding the same catalog-name overrides as 473-478, 3 of 4 subtests pass; `testCreateCatalog` fails because after `metalake.dropCatalog` + `loadMetalakeSync`, the catalog is still present in `catalogConnectors` on 446-451 while correctly removed on 469+. Appears to be a pre-existing 446-451 issue. **Question:** For 446-451, should we keep the test `@Disabled` (matches main, address `drop_catalog` in a follow-up) or investigate the fix in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
