sachinnn99 commented on code in PR #10748:
URL: https://github.com/apache/gravitino/pull/10748#discussion_r3088230215
##########
docs/trino-connector/configuration.md:
##########
@@ -16,12 +16,14 @@ license: "This software is licensed under the Apache
License version 2."
| gravitino.trino.skip-version-validation | boolean | false
| The `gravitino.trino.skip-version-validation` defines whether to skip Trino
version validation. Gravitino supports Trino versions between 435 and 478. If
this option is `true`, unsupported Trino versions can still be used, but
compatibility is not guaranteed.
| No | 1.0.0 |
| gravitino.client. | string | (none)
| The configuration key prefix for the Gravitino client config.
| No
| 1.0.0 |
| gravitino.trino.skip-catalog-patterns | string | (none)
| The `gravitino.trino.skip-catalog-patterns` defines a comma-separated list
of catalog name regex patterns that should be excluded from loading. For
example, `test_.*, .*_tmp` excludes all catalogs starting with `test_` or
ending with `_tmp`.
| No | 1.2.0 |
-| gravitino.use-single-metalake | boolean | true
| If `true`, only one metalake is used and catalogs are identified by
`<catalog_name>`. If `false`, multi-metalake mode is enabled and catalogs are
identified by `<metalake_name>.<catalog_name>`. Multi-metalake mode is
supported on Trino connector versions 469-472 and 473-478. It is not supported
on connector versions 446-451 or 452-468. | No | 1.2.0 |
+| gravitino.use-single-metalake | boolean | true
| If `true`, only one metalake is used and catalogs are identified by
`<catalog_name>`. If `false`, multi-metalake mode is enabled and catalogs are
identified by `<metalake_name>.<catalog_name>`. | No | 1.2.0 |
To configure the Gravitino client, use properties prefixed with
`gravitino.client.`. These properties will directly passed to the Gravitino
client.
**Note:** Invalid configuration properties will result in exceptions. Please
see [Gravitino Java client
configurations](../how-to-use-gravitino-client.md#gravitino-java-client-configuration)
for more support client configuration.
+Multi-metalake mode (`gravitino.use-single-metalake=false`) is supported on
Trino connector versions 469-478. It is not supported on versions 446-468. The
`DROP CATALOG` operation is not supported in multi-metalake mode.
+
Review Comment:
@diqiu50 Thanks for the feedback. I checked the code on main —
`supportCatalogNameWithMetalake()` returns `true` for 435-451 and `false` for
452-468. The connector version boundaries are 435-439, 440-445, 446-451,
452-468, so "435-465" doesn't align with a boundary.
Did you mean 435-451 should be documented as supported? Or should 452-468
also be enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
