bbiiaaoo commented on code in PR #10637:
URL: https://github.com/apache/gravitino/pull/10637#discussion_r3055313240
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/GravitinoLanceNameSpaceOperations.java:
##########
@@ -414,6 +407,60 @@ private <T> T[] buildChanges(
return Stream.concat(setPropertiesStream,
removePropertiesStream).toArray(arrayCreator);
}
+ private static CreateMode parseCreateMode(String instance, String mode) {
Review Comment:
Good catch. There is duplicated normalization logic between namespace
`parseCreateMode` and table `normalizeCreateMode`.
They are not fully identical because namespace mode is converted to an
internal enum, while table mode is normalized to a string property passed
downstream (and register mode also accepts `REGISTER` as an alias).
I’ll optimize this by extracting the shared token-normalization logic and
reusing it in both paths, while keeping the behavior-specific mappings
unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
