bbiiaaoo commented on code in PR #10637:
URL: https://github.com/apache/gravitino/pull/10637#discussion_r3055188564
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -138,19 +141,26 @@ public Response createTable(
@Produces("application/json")
@Timed(name = "create-empty-table." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
@ResponseMetered(name = "create-empty-table", absolute = true)
+ @SuppressWarnings("deprecation")
public Response createEmptyTable(
@PathParam("id") String tableId,
@QueryParam("delimiter") @DefaultValue(NAMESPACE_DELIMITER_DEFAULT)
String delimiter,
- CreateEmptyTableRequest request,
+ Map<String, Object> requestBody,
Review Comment:
Good question. We intentionally use `Map<String, Object>` here for backward
compatibility.
In lance-namespace 0.4.5, `CreateEmptyTableRequest` does not include a
`properties` field, but we still accept legacy request-body `properties` from
existing clients. Using `Object` allows us to safely normalize non-string JSON
values (for example numbers/booleans) into strings before passing them
downstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
