justinmclean opened a new issue, #10630:
URL: https://github.com/apache/gravitino/issues/10630

   ### What would you like to be improved?
   
   In TableOperationDispatcher.createTable(...), Gravitino first creates the 
table in the underlying catalog, then writes the TableEntity to the entity 
store.
   
   If store.put(tableEntity, true) fails, the exception is logged but 
swallowed, and the method still returns success.
   
   This can leave the external table created, even though Gravitino metadata 
was not persisted. Clients will receive a successful create-table response even 
though Gravitino is in an inconsistent state. 
   
   Location is TableOperationDispatcher.java (line 640)
   
   ### How should we improve?
   
   Do not swallow the store.put(...) failure. Propagate the exception so 
create-table fails instead of returning false success OR if best-effort 
behavior is intended, return an explicit partial-success/inconsistent-state 
result and add a test for this path.
   
   Add/modify an existing unit test to check for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to