justinmclean opened a new issue, #10629:
URL: https://github.com/apache/gravitino/issues/10629

   ### What would you like to be improved?
   
   GetTagForMetadataObjectFailureEvent accepts a name parameter in its 
constructor but never stores or exposes it.
   
   This makes the failure event inconsistent with the corresponding pre-event 
as GetTagForMetadataObjectPreEvent preserves tagName, but 
GetTagForMetadataObjectFailureEvent loses that context.
   
   As a result, event listeners cannot determine which tag lookup failed when 
handling GET_TAG_FOR_METADATA_OBJECT failures. This affects production-listener 
integrations because the event is emitted on the live server request path via 
TagEventDispatcher.
   
   ### How should we improve?
   
   Add a private final String tagName; field to 
GetTagForMetadataObjectFailureEvent, assign it from the constructor’s name 
argument, and expose it with a getter like tagName().
   
   Suggested tests:
   - Extend tag event tests to assert the failure event preserves tagName
   - Verify the emitted failure event contains the requested tag name after a 
failed getTagForMetadataObject(...)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to