SemyonSinchenko commented on code in PR #745: URL: https://github.com/apache/incubator-graphar/pull/745#discussion_r2324471341
########## maven-projects/info/src/test/java/org/apache/graphar/info/GraphLoaderTest.java: ########## Review Comment: What do you think about adding tests for resolving for common schemes? Just to check that our resolving is working fine. Like `s3://`, `hdfs://`, `o3fs://`, `ofs://`, `gs://`, etc.? Not reading but just resolving. That for the most common protocols, we will be sure, that resolving of relative paths is working fine. ########## maven-projects/info/src/test/java/org/apache/graphar/info/LocalFileSystemStringStreamLoader.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.graphar.info; + +import java.io.FileInputStream; +import java.io.IOException; +import java.io.InputStream; +import java.net.URI; +import org.apache.graphar.info.loader.StreamGraphInfoLoader; + +public class LocalFileSystemStringStreamLoader extends StreamGraphInfoLoader { Review Comment: What do you think about moving it to `org.apache.graphar.info.loader.impl`? I mean it can be useful, especially for unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
