yangxk1 commented on code in PR #745:
URL: https://github.com/apache/incubator-graphar/pull/745#discussion_r2324231027


##########
maven-projects/info/src/main/java/org/apache/graphar/util/PathUtil.java:
##########
@@ -20,8 +20,22 @@
 package org.apache.graphar.util;
 
 public class PathUtil {
+
+    public static String resolvePath(String basePath, String subPath) {

Review Comment:
   +1, after using URI, we don’t need to do string judgment and splicing 
frequently. For example, we now have to store the chunk files of vertex and 
edge, because the paths are spliced ​​with prefix in graph.yml. After using the 
URI, we can set prefix=s3://xxx in vertex.yml and set prefiix=file:///xxx in 
edge.yml, so that data can be separated and stored without making many 
judgments on the path.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to