BaldDemian commented on PR #3458: URL: https://github.com/apache/fory/pull/3458#issuecomment-4020881256
After some investigation, I can confirm that the misaligned address access UB mentioned above is caused by the way `buffer.h` creates types that require alignment using `reinterpret_cast` directly, e.g. https://github.com/apache/fory/blob/ed586af222327bb2c3e7220832c991f211920005/cpp/fory/util/buffer.h#L885-L892 In this method, `int16` requires 2 byte alignment, but `reinterpret_cast` cannot guarantee or check this requirement. I am preparing a PR to fix this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
