BaldDemian opened a new pull request, #3458:
URL: https://github.com/apache/fory/pull/3458

   <!--
   **Thanks for contributing to Apache Fory™.**
   
   **If this is your first time opening a PR on fory, you can refer to 
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).**
   
   Contribution Checklist
   
       - The **Apache Fory™** community has requirements on the naming of pr 
titles. You can also find instructions in 
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).
   
       - Apache Fory™ has a strong focus on performance. If the PR you submit 
will have an impact on performance, please benchmark it first and provide the 
benchmark result here.
   -->
   
   ## Why?
   
   Close https://github.com/apache/fory/issues/1203
   
   ## What does this PR do?
   
   - Add ASan and UBSan integration in `.bazelrc`.
   - I noticed that directly running `bazel test $(bazel query //cpp/...)` 
triggers compilation errors because the `--config=x86_64` flag is not provided. 
In the new CI Python script `run_ci.py`, the `cpp.py` task invoked by it indeed 
contains a check for this flag:
     
https://github.com/apache/fory/blob/af6e8b25e8c2d188cba2d99ccb276c47ec6c9c31/ci/tasks/cpp.py#L40-L41
     The `run_ci.sh` script does not contain this check. Although this script 
appears to no longer be used, I still added the corresponding flag check there.
   Similarly, I also added documentation about this flag in `AGENTS.md`.
   
   - In `ci.yml`, I added a new job to enable tests with sanitizers in CI. 
Currently, this job only runs on ubuntu-latest.
   
   ## Related issues
   
   https://github.com/apache/fory/issues/1203
   
   
   ## Benchmark
   
   <!--
   When the PR has an impact on performance (if you don't know whether the PR 
will have an impact on performance, you can submit the PR first, and if it will 
have impact on performance, the code reviewer will explain it), be sure to 
attach a benchmark data here.
   
   Delete section if not applicable.
   -->
   I believe this feature only introduces extra burden during testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to