sapienza88 commented on PR #942: URL: https://github.com/apache/fesod/pull/942#issuecomment-4922216574
> > my understanding is that fesod does not support reading a sheet by column (only by rows) but it can write to a square set of cells, is that correct? where this logic of the this PR should also be propagated? which classes are also concerned with reading with a column index? PS: I added some tests here. > > Reading and converting the data in cells is achieved through the `ReadListener` interface. Please refer to this method to see if it provides any inspiration or assistance to you. > > https://github.com/apache/fesod/blob/d7fae5a40f5a537582663df86c50cf413154a5f6/fesod-sheet/src/main/java/org/apache/fesod/sheet/read/listener/ModelBuildEventListener.java#L65 > > BTW, I'm a little worried about this PR. Could you please start the preliminary discussion in the issue and provide your proposed solution? (e.g. #941 ) > > I didn't mean any offense, the other members of the community generally do not discuss proposals in the PR. This would help save the time for the code review. I meant not "in n cells" but in rows AND columns. And not a listnener function. That was a severe limitation of fesod thankfully this PR comes to the rescue, the idea is clear and simple (read a sheet by rows and columns) i think there is no need to describe it more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
