sapienza88 commented on PR #942: URL: https://github.com/apache/fesod/pull/942#issuecomment-4886071460
> > No I cannot make sure it compiles on CI, maybe locally but not on CI > > Hi, may I ask if this is a draft PR? > > I haven't seen any complete implementation logic for this new parameter, and there are no use cases of reading Excel files in the unit test code either. not a draft PR, i will extend it to add a complete implementation logic for the new parameter, as well as a test based on reading dummy data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
