sakshichitnis27 commented on code in PR #20664:
URL: https://github.com/apache/druid/pull/20664#discussion_r4359600721
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteNestedDataQueryTest.java:
##########
@@ -6998,6 +6998,20 @@ public void testJsonQueryArrayNullArray()
.run();
}
+ @Test
+ public void testUnnestJsonQueryArrayOfConstantJson()
Review Comment:
Hi @FrankChen021, thanks for the review. I’ve added tests for all three
cases: an empty array, a JSON path that doesn’t exist, and
ARRAY<ARRAY<COMPLEX<json>>>.
The missing-path and nested-array cases failed with the original fix, so I
extended it:
DruidRexExecutor now checks the element type through nested arrays.
DruidLogicalValuesRule now accepts null ARRAY literals. A missing path
reduces to one, and it used to fail planning.
I’ve updated the PR description and release note to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
