amaechler commented on code in PR #20694:
URL: https://github.com/apache/druid/pull/20694#discussion_r4361451629
##########
.github/scripts/auto-add-milestone.sh:
##########
@@ -19,13 +19,18 @@ set -e
get_milestone_number() {
local milestone_title="$1"
- local number=$(gh api "repos/$REPOSITORY/milestones" --jq ".[] |
select(.title==\"$milestone_title\") | .number")
+ local number=$(gh api "repos/$REPOSITORY/milestones?state=all&per_page=100"
--paginate --jq ".[] | select(.title==\"$milestone_title\") | .number")
Review Comment:
Fixed in 4c16270842: `number` is now declared on its own line, and the
function returns 1 if the lookup fails, so an API error no longer falls through
to the create call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
