FrankChen021 commented on PR #20564: URL: https://github.com/apache/druid/pull/20564#issuecomment-6159581350
for CodeQL findings, we don't have a general rule to handle them. for example: https://github.com/apache/druid/pull/20521 it reports problems in test cases. Should we fix it or not , I think it's both not clear for authors and reviewers because the CI is always green. If findings should be treated case by case, it's hard to manage them. I think that's one reason today we have more than 3.3K+ findings in the whole repo. I don't have a good idea about this, but I think we can discuss it first (may be in the mailing thread) to address it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
