FrankChen021 commented on code in PR #20417:
URL: https://github.com/apache/druid/pull/20417#discussion_r4111359015
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java:
##########
@@ -1437,16 +1438,17 @@ public void taskAddedOrUpdated(final TaskAnnouncement
announcement, final Worker
taskItem = tasks.get(taskId);
if (taskItem == null) {
// Try to find information about it in the TaskStorage
- Optional<TaskStatus> knownStatusInStorage =
taskStorage.getStatus(taskId);
+ final TaskInfo taskInfo = taskStorage.getTaskInfo(taskId);
Review Comment:
I rechecked the current head and all 16 changed files. This case is still
not actually ignored: when `getTask(taskId)` is absent, the `break` exits only
the `knownStatusInStorage` switch, leaving `taskItem` null; the common
`taskItem == null` branch then sets `shouldShutdownTask` for a non-complete
RUNNING announcement, and the method calls `workerHolder.shutdownTask(taskId)`.
Please bypass that shutdown path for the missing-payload case.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
