kfaraz commented on code in PR #20417:
URL: https://github.com/apache/druid/pull/20417#discussion_r4105284881
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java:
##########
@@ -1437,16 +1438,17 @@ public void taskAddedOrUpdated(final TaskAnnouncement
announcement, final Worker
taskItem = tasks.get(taskId);
if (taskItem == null) {
// Try to find information about it in the TaskStorage
- Optional<TaskStatus> knownStatusInStorage =
taskStorage.getStatus(taskId);
+ final TaskInfo taskInfo = taskStorage.getTaskInfo(taskId);
Review Comment:
Hmm, I guess that seems reasonable because whenever the Overlord restarts,
it would try to do a full sync with the middle managers, thereby getting
announcements of all past completed tasks. I suppose we could avoid
deserializing the payload for all of those tasks, especially since this entire
logic is inside a synchronized block.
Let me make the necessary changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
