chenlinzhong commented on code in PR #18799: URL: https://github.com/apache/doris/pull/18799#discussion_r1171208999
########## fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java: ########## @@ -1458,4 +1483,56 @@ private int getFirstNotNullObject(Object[] column, int numRows, long nullMapAddr } return i; } + + // only used by nebula-graph + public static Object tranferToDorisObject(ValueWrapper value) { Review Comment: > now all result is save as object, you just check the object instanceof ValueWrapper, and then convert to string..... Don't you think there's a lot of redundant code now, Why not unify the result set ? What's the difference between convert in getBlock function and convert in copyBatchIntResult ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org