chenlinzhong commented on code in PR #18799:
URL: https://github.com/apache/doris/pull/18799#discussion_r1171040346
##########
fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java:
##########
@@ -1458,4 +1483,56 @@ private int getFirstNotNullObject(Object[] column, int
numRows, long nullMapAddr
}
return i;
}
+
+ // only used by nebula-graph
+ public static Object tranferToDorisObject(ValueWrapper value) {
Review Comment:
> why not like other database doing convert the work, if you put convert in
`getBlock` function, it's will have significant performance impact. eg int
type: `copyBatchIntResult`, it convert some object from different database to
int, so you need write the else if (..... graph object), then convert to int
data insert into column
Graph database is different from relational database , The resultset cannot
be directly used, and needs to be converted according to different scenarios,
such as using 'vertex' as the varchar type here
As for performance, there may be issues. Currently, it seems that the impact
is not significant, and this conversion operation is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
